-
-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] update variable values to include name conversion #301
base: main
Are you sure you want to change the base?
Conversation
Hey @burn2delete, thanks for the PR. Sorry for the late reply, I was on vacation. Could you please write me a quick description of what this PR does? |
Pull Request Test Coverage Report for Build 7591706637
💛 - Coveralls |
@lukasoppermann I pulled down this branch locally and confirmed it's working as expected (at least for me).
This PR appears to be patching the desired behavior, as called out here. Before(with Figma Token and Typography selected) {
"collectionname": {
"color1": { ⚠️ modes are skipped
"type": "color",
"value": "#494c5bff",
"blendMode": "normal"
},
}
},
"typography": {
...
}
} After(with Figma Token and Typography selected) {
"collectionname": {
"light_mode": { ✅ modes are back
"color1": {
"type": "color",
"value": "#494c5bff",
"blendMode": "normal"
},
}
},
"dark_mode": {
"color1": {
"type": "color",
"value": "#b5bac9ff",
"blendMode": "normal"
},
}
},
},
"typography": {
...
}
} This plugin is great. IMO it's the cleanest. If this can get patched, it will become my "go-to" plugin. Currently using the fork locally, but this has got to be a common painpoint |
Hey @matthova, thanks for checking it out. We need to update this as there are conflicts. Once done we can merge. |
No description provided.